Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move combo counter to ruleset-specific HUD components container #26249

Merged
merged 13 commits into from
Aug 8, 2024

Add back removed xmldoc

88c5997
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Move combo counter to ruleset-specific HUD components container #26249

Add back removed xmldoc
88c5997
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Aug 8, 2024 in 1s

10316 passed, 2 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10392 tests were completed in 2862s with 10316 passed, 2 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn 33✅ 1❌ 6s
osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations 11✅ 1❌ 21s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn

✅ TestConstructor
✅ TestConstructor
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
❌ TestLeadInProducesCorrectStartTime(2000,0)
	check first frame time: Expected: 0.0d +/- 100.0d
	  But was:  218.1328d
	  Off by:   -218.1328d
	
✅ TestLeadInProducesCorrectStartTime(2000,0)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)

❌ osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations

✅ TestBestRulesetIsRecommended
✅ TestBestRulesetIsRecommended
✅ TestConstructor
✅ TestConstructor
❌ TestCorrectStarRatingIsUsed
	"recommended beatmap displayed" timed out
✅ TestCorrectStarRatingIsUsed
✅ TestCurrentRulesetIsRecommended
✅ TestCurrentRulesetIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestSecondBestRulesetIsRecommended
✅ TestSecondBestRulesetIsRecommended

Annotations

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestLeadInProducesCorrectStartTime(2000,0)

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  check first frame time: Expected: 0.0d +/- 100.0d
    But was:  218.1328d
    Off by:   -218.1328d
  
Raw output
check first frame time: Expected: 0.0d +/- 100.0d
  But was:  218.1328d
  Off by:   -218.1328d

   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestCorrectStarRatingIsUsed

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)