Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argon/classic osu!mania combo counter #26254

Merged
merged 23 commits into from
Aug 15, 2024
Merged

Add argon/classic osu!mania combo counter #26254

merged 23 commits into from
Aug 15, 2024

Commits on Dec 30, 2023

  1. Abstractify LegacyComboCounter to re-use for mania

    @frenzibyte
    frenzibyte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    78cb6b6 View commit details
    Browse the repository at this point in the history

  2. Add legacy mania combo counter lookups

    @frenzibyte
    frenzibyte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    ece532b View commit details
    Browse the repository at this point in the history

  3. Add legacy mania combo counter implementation

    @frenzibyte
    frenzibyte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    8be3f4f View commit details
    Browse the repository at this point in the history

  4. Add very basic argon mania combo counter implementation

    @frenzibyte
    frenzibyte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    408287e View commit details
    Browse the repository at this point in the history

  5. Add various visual test coverage

    @frenzibyte
    frenzibyte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    95961dc View commit details
    Browse the repository at this point in the history

  6. Disable "closest" anchor in mania combo counter for convenience

    @frenzibyte
    frenzibyte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    01219fa View commit details
    Browse the repository at this point in the history

  7. Fix failing tests

    @frenzibyte
    frenzibyte committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    02f5ea2 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Merge branch 'master' into mania-combo-counter

    @peppy
    peppy committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e645651 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Update in line with new changes

    @peppy
    peppy committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    80c8140 View commit details
    Browse the repository at this point in the history

  2. Remove SupportsClosestAnchor for the time being 

    This may have had a good reason to be added, but I can't find that
reason, so let's keep things simple for the time being.
    @peppy
    peppy committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7666e8b View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary UsesFixedAnchor specifications

    @peppy
    peppy committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3f20f05 View commit details
    Browse the repository at this point in the history

  4. Simplify argon mania combo counter implementation by sharing with bas… 

    …e counter
    @peppy
    peppy committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    161734a View commit details
    Browse the repository at this point in the history

  5. Fix migration failure due to change in class name

    @peppy
    peppy committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f6ada68 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Standardise skin transformer code structure

    @peppy
    peppy committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d2eb6cc View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Fix file access test failure by forcing retries 

    See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.
    @peppy
    peppy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    dd9705b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mania-combo-counter

    @peppy
    peppy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e465049 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect anchor handling in ArgonManiaComboCounter

    @peppy
    peppy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7c142bc View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Remove position-flipping logic from mania combo counters for now 

    We need a general method to do this amicably, such as an HUD target that flips the position of its children when the direction is flipped. Something to consider later.
    @frenzibyte
    frenzibyte committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ff1ab2b View commit details
    Browse the repository at this point in the history

  2. Remove x symbol from argon mania combo counter

    @frenzibyte
    frenzibyte committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3a4546d View commit details
    Browse the repository at this point in the history

  3. Actually bring back position-flipping logic and disable "closest" anchor

    @frenzibyte
    frenzibyte committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    66adddb View commit details
    Browse the repository at this point in the history

  4. Fix beatmap skin on mania breaking HUD apart

    @frenzibyte
    frenzibyte committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a421231 View commit details
    Browse the repository at this point in the history

  5. Update code order to match everything else

    @frenzibyte
    frenzibyte committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    358572e View commit details
    Browse the repository at this point in the history

  6. Try make code look better

    @frenzibyte
    frenzibyte committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7427237 View commit details
    Browse the repository at this point in the history