Refactor scale handling in editor to facilitate reuse #26643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only is this simpler, but it also is more correct (for explanation why, try holding both shift keys while dragging, and just releasing one of them - the previous code would briefly turn aspect ratio off).
Being able to flip doesn't really feel all that good and `master` was already clamping, so let's just bring that back for now. Flipping can be reconsidered in a follow-up if it actually can be made to behave well.
It doesn't make sense and it wasn't doing the right thing.
|
I've done a pass on this. Mostly code quality type stuff, but also some actual fixes/behavioural changes included. Of note: 070668c, 3e34b2d, 128029e (explanations in commit messages). This is looking pretty good in general though. Aspect ratio finally having a chance to work correctly is nice. @OliBomby a second look to ensure I haven't broken anything would be appreciated if you are willing to have one. |
whooops.
bdach
approved these changes
May 23, 2024
|
I've checked your changes, I think it looks good. I was skeptical about the clamping but I agree its weird when the cursor stops moving with the anchor you're holding, so clamping prevents that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon the convention created in #24341 to refactor scale handling to a
SelectionScaleHandler.I also changed the logic to accept the scale as a multiplier instead of a coordinate offset. I think this makes it easier to understand and makes implementing a future scale popover easier.
Also added shift hotkey for preserving aspect ratio on scale, because it was very simple to implement with some of the code I copied from the rotation scale handler. Feature mentioned in #24161
I apologise for the huge diff. Its hard to split a refactor like this into parts, because the program wont work currectly until every scale operator is refactored.