Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix star counter decrease animation being delayed when current is over displayed star count #27205

Merged
merged 3 commits into from
Feb 17, 2024

Fix star counter decrease animation being delayed when current is ove…

7a74eaa
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix star counter decrease animation being delayed when current is over displayed star count #27205

Fix star counter decrease animation being delayed when current is ove…
7a74eaa
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Feb 17, 2024 in 0s

Test Results (macOS, MultiThreaded) ❌

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

5611 tests were completed in 2095s with 5558 passed, 1 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen 21✔️ 1❌ 55s

❌ osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen

✔️ TestAudioLeadIn
✔️ TestConstructor
✔️ TestDelayedStart
✔️ TestGameplayRateAdjust
✔️ TestGeneral(1)
✔️ TestGeneral(4)
✔️ TestGeneral(9)
✔️ TestIntroStoryboardElement
✔️ TestMostInSyncUserIsAudioSource
✔️ TestMultipleStartRequests
❌ TestPlayersCatchUpAfterFallingBehind
	TearDown : System.TimeoutException : "wait for screen load" timed out
✔️ TestPlayersContinueWhileOthersBuffer
✔️ TestPlayersDoNotStartSimultaneouslyIfBufferingForMaximumStartDelay
✔️ TestPlayersLeaveWhileSpectating
✔️ TestPlayersMustStartSimultaneously
✔️ TestSpectatingDuringGameplay
✔️ TestSpectatingDuringGameplayWithLateFrames
✔️ TestSpectatorPlayerInteractiveElementsHidden
✔️ TestTeamDisplay
✔️ TestTeams(16)
✔️ TestTeams(2)
✔️ TestTimeDoesNotProgressWhileAllPlayersPaused

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen ► TestPlayersCatchUpAfterFallingBehind

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "wait for screen load" timed out
Raw output
TearDown : System.TimeoutException : "wait for screen load" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)