Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursormiddle not using the same source as cursor #27964

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Fix cursormiddle not using the same source as cursor #27964

merged 3 commits into from
Apr 22, 2024

Conversation

smoogipoo
Copy link
Contributor

Fixes #27952

Relevant code in osu!stable:

cursor2.Texture = TextureManager.Load(@"cursormiddle", t_cursor.Source);

t_cursor.Source represents the final skin where the cursor texture was sourced from, not where it's allowed to be source from.

@peppy peppy self-requested a review April 22, 2024 06:12
@peppy peppy merged commit 877ca48 into ppy:master Apr 22, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:skinning ruleset/osu! size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor trail becomes long/smooth when cursortrail.png and cursormiddle.png are not present in the skin's files
2 participants
@smoogipoo @peppy