Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing distance spacing multiplier hiding the distance snap grid when it's already shown #28066

Merged
merged 3 commits into from
May 2, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented May 2, 2024

Closes #28042.

Please see tests or video below for intended behaviour.

2024-05-02.14-24-55.mp4

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One may say that the key bindings here are counter intuitive (a key that is required to be held to adjust an active grid shouldn't be one which temporarily disables the grid) but let's just look away for now.

This does the job.

@peppy peppy merged commit 2d02404 into ppy:master May 2, 2024
13 of 17 checks passed
@bdach bdach deleted the distance-snap-grid-spacing-change-hides-it branch May 2, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjusting distance snap's distance with the keybindings toggles distance snap off
2 participants