Add mod display and unranked indicator to new song select footer #28141
Conversation
…modes This is especially visible when reloading `SongSelectFooterV2` while multiple mods are already selected. The mods will appear expanded then contract.
Fading out the mod display looks quite ugly, since alpha is applied per mod sprite, introducing bad visual on the intersection between mods.
|
the right edge of the unranked indicator doesn't seem to align (in the sheared sense...) with the button below it |
Is it hard to have it display until it doesn't fit? And potentially in the tooltip? I'm wondering if we need a compact version which shows that there are non-default settings while not being the full settings text (just a slightly extended colour bar). |
Figma uses gaussian blur for shadows while o!f uses linear fade (hacky repurposed masking shader). I have a way to fake gaussian blur for simple shapes without any overhead, but there's no way to change that without big refactoring unfortunately. |
It's possible (I tried and it worked), but with only one customised mod, adding any other mod will fall back to text mode, so I scrapped the idea of showing them in the first place altogether. The tooltip I added for "X mods" text already shows the mod in its extended form. |
|
Might need #19750 to distinguish modified rate adjust mods without having the extended information state. Still want to see the rate multiplier though. I feel like the tooltip for 5+ mods seems to be lacking information in it's current state. Individual mod tooltips show the mod name and settings modified but doesn't in this grouped 5+ mod tooltip. Was recommending to reuse or copy the mod preset tooltip that has this information w/ consistent mod icons. Also |
I went with a different design myself because the purpose of this tooltip is to show what the display couldn't due to its insufficient width. Adding extra information like the name next to the mod feels too much information to me, and even if we add it, it feels weird that we're only showing this extra information only when there are too many mods selected. |
Preview:
CleanShot.2024-05-10.at.07.21.40.mp4
CleanShot.2024-05-10.at.07.34.46.mp4
Notes:
I've had to disable display of extended information for mods such as DT, as displaying only one of them eats up the whole display:
I'm not sure what's the best way to display those, or if this indicates a flaw in the current design of the mod display (cc @peppy).
There is supposed to be a drop-shadow behind the background of the "mod display" part of the bar above the button, but when adding it, the bottom left edge of the display becomes overfilled with shadow, making it look ugly:
It may not be as noticable (maybe because of the background being dark though). If there is nothing looking off with the image above then I can add the drop shadow (diff, for real testing).
There are different other ways for displaying the unranked indicator proposed in discord, such as adding a red outline to the mod display, or adding a warning icon next to the mod display with an explanatory tooltip. I'm not really a fan of any of those proposals as it sort-of defeats the purpose of the indicator, which is to make the user well informed about their mod selection without having them hover over it.