Remove TreatWarningsAsErrors flags from local builds for developer convenience
#28198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been discussed in here and here. This flag has been causing unnecessary hurdles with development, such as builds failing when using obsolete methods while temporarily testing changes, or when commenting code that cuts off all usages to a field/property/constant (this is especially frusturating with hot reload, because removing members is not fully supported, and the developer loses the point of having hot reload).
Our workflows already append the
-warnaserrorflag during builds, so all warnings are still treated as errors and fail CI (tested in here).In addition, Rider does a pretty good job of warning developers if there are warnings in build, so that should not be a concern when removing this flag (missing warnings during a PR):