Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy mania note body animation not resetting sometimes #28339

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix legacy mania note body animation not resetting sometimes #28339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,7 @@ private void applyCustomUpdateState(DrawableHitObject hitObject, ArmedState stat
private void onIsHittingChanged(ValueChangedEvent<bool> isHitting)
{
if (bodySprite is TextureAnimation bodyAnimation)
{
bodyAnimation.GotoFrame(0);
bodyAnimation.IsPlaying = isHitting.NewValue;
}

if (lightContainer == null)
return;
Expand Down Expand Up @@ -219,6 +216,9 @@ protected override void Update()
{
base.Update();

if (!isHitting.Value)
(bodySprite as TextureAnimation)?.GotoFrame(0);

if (holdNote.Body.HasHoldBreak)
missFadeTime.Value = holdNote.Body.Result.TimeAbsolute;

Expand Down
Loading