Add support for combo counter from legacy mania skins #28391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEZIC
force-pushed
the
mania-legacy-combo-counter
branch
from
95ad319
to
11f40c4
Compare
|
Is this related to #26254? |
It sure looks like this to me, and some of the changes made in this pull on a 5-second skim make it dead-on-arrival as far as I'm concerned. The other series has the right idea on how to execute this. This PR does not. |
bdach
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Just to elaborate on what I find objectionable about this change for future reference.
We added ruleset-specific HUD layers for the express purpose of implementing this sort of thing. So bypassing them entirely via means such as the ones introduced in this PR will be met with instant rejection.
| @@ -34,5 +37,29 @@ protected LegacySkinTransformer(ISkin skin) | |||
|
|
|||
| return base.GetSample(sampleInfo); | |||
| } | |||
|
|
|||
| protected Drawable? ReplaceBaseComboCounter(ISkinComponentLookup lookup) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all code from LegacyComboCounter to LegacyBaseComboCounter. We don't need ISerialisableDrawable implementation for LegacyManiaComboCounter. I made it like this because we can't move mania ComboCounter without configuration changes.
Made LegacyManiaComboCounter from LegacyBaseComboCounter.
Move logic of hiding default combo counter element from CatchLegacySkinTransformer to LegacySkinTransformer because we need to hide default combo counter in mania as well.
Add ShouldRoll property to BaseComboCounter. That property toggles rolling of combo counter and removes 'x' symbol at the end of it.