Fix playlist total time not considering rate adjust mods #28399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Jun 5, 2024
peppy
changed the title
matheus-cesquim
commented
Jun 6, 2024
Comment on lines
49
to
55
| IEnumerable<Mod> modList = []; | ||
| if (p.RequiredMods.Length > 0) | ||
| { | ||
| var ruleset = p.Beatmap.Ruleset.CreateInstance(); | ||
| modList = p.RequiredMods.Select(mod => mod.ToMod(ruleset)); | ||
| } | ||
| double rate = ModUtils.CalculateRateWithMods(modList); |
There was a problem hiding this comment.
Created this validation to deal with the problem of instancing ruleset every time for every map
peppy
approved these changes
Jun 7, 2024
bdach
approved these changes
Jun 7, 2024
| if (p.RequiredMods.Length > 0) | ||
| { | ||
| var ruleset = p.Beatmap.Ruleset.CreateInstance(); | ||
| rate = ModUtils.CalculateRateWithMods(p.RequiredMods.Select(mod => mod.ToMod(ruleset))); |
There was a problem hiding this comment.
This isn't going to work for wind up/down but I guess this is better than nothing for now.
bdach
added a commit
to bdach/osu
that referenced
this pull request
Jun 25, 2024
…e present Regressed in ppy#28399. To reproduce, enter a playlist that has an item with a rate-changing mod (rather than create it yourself). This is happening because `APIRuleset` has `CreateInstance()` unimplemented: https://github.com/ppy/osu/blob/b4cefe0cc2fda0ab4b5af6138ee158bd32262f9a/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs#L159 and only triggers when the playlist items in question originate from web. This is why it is bad to have interface implementations throw outside of maybe mock implementations for tests. `CreateInstance()` is a scourge elsewhere in general, we need way less of it in the codebase (because while convenient, it's also problematic to implement in online contexts, and also expensive because reflection).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28398