Disable the automatic offset adjustment button if the offset of the previous play was 0 #28481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What "bug"? This may be aesthetic / UX at best, but surely there's no bug here? What harm could the button cause if offset of the last play was 0? |
|
Yes, it is somewhat uncomfortable but does not cause serious problems. |
peppy
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I luckily found this bug when I retried with an offset of 0. It is almost impossible to reproduce outside of a test scene, but I guarantee it was there once.
I have disabled the button in the event, but if there is no change after adjusting it, it does not work.
It is strange when the button is enabled when no offset adjustment is needed in the first place, so we made sure to check it first.