Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject" #28500

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

Givikap120
Copy link
Contributor

Before, timed difficulty attributes was bound to difficulty hit objects. This caused bugs like this:

osu.2024-06-16.17-10-17-591.mp4

As we can see here, spinner is using difficulty attributes from the second object, making it appear like the spinner itself gives 19pp.
Changing timed difficulty attributes to calculating per beatmap hitobject make it correct:

osu.2024-06-16.17-11-07-225.mp4

@smoogipoo
Copy link
Contributor

  • Needs CI resolution.
  • Needs test fixes.
  • Reword the commit to be more descriptive. This needs a force push - I can't do this for you. Please use this as general guidance for future PRs.

@Givikap120
Copy link
Contributor Author

Givikap120 commented Jun 17, 2024

  • Needs CI resolution.

What is CI resolution?

  • Reword the commit to be more descriptive. This needs a force push - I can't do this for you. Please use this as general guidance for future PRs.

By commit you mean first and only commit named "fixed the bug"? Because PR name seem descriptive to me as it exactly what PR does: calculating difficulty attributes for each hit object instead of for each difficulty hit object

@bdach
Copy link
Collaborator

bdach commented Jun 17, 2024

What is CI resolution?

Fix the red crosses shown below.

By commit you mean first and only commit named "fixed the bug"?

Commit messages are as important - if not more than - PR titles so please give both due considerations.

and fixed one minor CI code quality thing
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 18, 2024
@Givikap120
Copy link
Contributor Author

okay it still fails but I think it's not my fault now

@smoogipoo smoogipoo merged commit 17151e8 into ppy:master Jun 28, 2024
13 of 17 checks passed
@Givikap120 Givikap120 deleted the pp_counter_fix branch July 1, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants