Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject" #28500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, timed difficulty attributes was bound to difficulty hit objects. This caused bugs like this:
osu.2024-06-16.17-10-17-591.mp4
As we can see here, spinner is using difficulty attributes from the second object, making it appear like the spinner itself gives 19pp.
Changing timed difficulty attributes to calculating per beatmap hitobject make it correct:
osu.2024-06-16.17-11-07-225.mp4