Display breaks on editor timeline & allow manually adjusting their duration #28523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
peppy
approved these changes
Jun 19, 2024
bdach
commented
Jun 19, 2024
| @@ -204,12 +204,12 @@ private void updateState() | |||
| { | |||
| bool active = IsHovered || IsDragged; | |||
|
|
|||
| var colour = colours.GreyCarmineLighter; | |||
There was a problem hiding this comment.
Uh... sure about this? This colour was matching bottom timeline:
Purple is kiai.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #14330
2024-06-18.16-35-27.mp4
This is a half-baked diff:
but the code size has already grown by quite a bit so I wanna get this one out as a first step at least. Aforementioned points will be addressed in future pulls.