Reimplement stable polygon tool #28538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Aug 19, 2024
|
|
||
| switch (e.Key) | ||
| { | ||
| case Key.D: |
There was a problem hiding this comment.
I guess we can match this for now, but the stable code comment is not confidence instilling:
peppy
previously approved these changes
Aug 19, 2024
peppy
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19970.
2024-06-20.16-32-40.mp4
While yes, #26303 is also a thing, in discussing with users I don't think that grids are going to be able to deprecate this feature.
Logic transcribed verbatim from stable.