Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy skin hold note bodies not appearing when scrolling upwards #28570

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jun 25, 2024

- Closes ppy#28567.
- Regressed in ppy#28466.

Bit of a facepalm moment innit...
@bdach bdach added ruleset/osu!mania area:skinning next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Jun 25, 2024
@bdach bdach requested review from smoogipoo and a team June 25, 2024 08:37
@peppy peppy self-requested a review June 25, 2024 10:08
@peppy peppy merged commit c5c3094 into ppy:master Jun 25, 2024
13 of 17 checks passed
@bdach bdach deleted the fix-upscroll branch June 25, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:skinning next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! ruleset/osu!mania size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Osu!mania hold bodys on long notes not appearing properly
2 participants