Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes
Peaks
skill and moves all of the combined calculation into the taiko difficulty calculator. The idea is that having skills within skills isn't really a good design, especially sincePeaks
skill was calling processing manually instead of passing it through the main difficulty calculation abstractions, and also enables backosu-tools
per-skill strain visualization since it assumes that skills will always be present in theDifficultyCalculator.Skills[]
arrayActual difficulty/performance values shouldn't change and from my limited testing seems like values didn't change.
This also changes the way difficulty calculator fetch skills from hardcoded array indexing to
skills.First(x=> x is RequiredSkill)
which I'd want to change in all difficulty calculators eventually