Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out taiko Peaks skill #28596

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Jun 25, 2024

This change removes Peaks skill and moves all of the combined calculation into the taiko difficulty calculator. The idea is that having skills within skills isn't really a good design, especially since Peaks skill was calling processing manually instead of passing it through the main difficulty calculation abstractions, and also enables back osu-tools per-skill strain visualization since it assumes that skills will always be present in the DifficultyCalculator.Skills[] array

Actual difficulty/performance values shouldn't change and from my limited testing seems like values didn't change.

This also changes the way difficulty calculator fetch skills from hardcoded array indexing to skills.First(x=> x is RequiredSkill) which I'd want to change in all difficulty calculators eventually

@smoogipoo
Copy link
Contributor

!diffcalc

RULESET=taiko

Copy link

github-actions bot commented Jun 26, 2024

@smoogipoo smoogipoo merged commit 9039ec3 into ppy:master Jun 26, 2024
11 of 17 checks passed
@stanriders stanriders deleted the remove-peaks-skill branch June 26, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Deployed
Development

Successfully merging this pull request may close these issues.

2 participants