Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always log missing official build attribute #28606

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

smoogipoo
Copy link
Contributor

This is normally "logged" (via a notification) here:

if (game.IsDeployedBuild && version != lastVersion)
{
// only show a notification if we've previously saved a version to the config file (ie. not the first run).
if (!string.IsNullOrEmpty(lastVersion))
Notifications.Post(new UpdateCompleteNotification(version));
if (RuntimeInfo.EntryAssembly.GetCustomAttribute<OfficialBuildAttribute>() == null)
Notifications.Post(new SimpleNotification { Text = NotificationsStrings.NotOfficialBuild });
}

... but this only happens once on a new version of the game. In particular, it makes it difficult for us developers to understand what went wrong. This should help with figuring out the appropriate response to re-occurrences of #28556.

I also don't particularly care about translations here, only that the text is the same as the other case.

@peppy peppy merged commit 67be43b into ppy:master Jun 26, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants