Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix break generation not accounting for concurrent hitobjects correctly #28630

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Fix break generation not accounting for concurrent hitobjects correctly #28630

merged 5 commits into from
Jun 27, 2024

Commits on Jun 27, 2024

  1. Add failing test coverage of osu!mania automated break creation scena… 

    …rios
    @peppy
    peppy committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    bbacfc8 View commit details
    Browse the repository at this point in the history

  2. Fix break generation not accounting for concurrent hitobjects correctly

    @peppy
    peppy committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7ef7e5f View commit details
    Browse the repository at this point in the history

  3. Add safety test coverage for removal of breaks at end of beatmap

    @bdach
    bdach committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    981340d View commit details
    Browse the repository at this point in the history

  4. Use GetLastObjectTime() for safety 

    Due to other circumstances this has no real effect, but may as well.
    @bdach
    bdach committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ef952bc View commit details
    Browse the repository at this point in the history

  5. Add note about implicit reliance on sort by start time

    @bdach
    bdach committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b1baa49 View commit details
    Browse the repository at this point in the history