Fix osu! dropdown no longer handling Enter key to select items
#28632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a refactor of `ThemeComparisonTestScene` to allow accessing a manual input manager.
I've also removed inheritance from `SearchTextBox` because it contains logic that might interfere with the internal implementation of dropdown search bars (focus logic and stuff).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enterkey to select dropdown menu items #28627The functionality of selecting a dropdown item by Enter has been changed to be triggered by a commit event from the dropdown search bar's text box, since the text box is in a focused state when the dropdown is open and therefore is the first to receive any input by the user (see ppy/osu-framework@b12e4b1).
The osu!-side implementation of the search bar was relying on
SearchTextBox, which has commits disabled, therefore Enter has no longer been working.This PR not only enables commits on the search bar, but also uses
OsuTextBoxdirectly to avoid any potential nuances from the focus logic inSearchTextBox/FocusedTextBox.