Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "playfield" skin layer to respect shifting playfield border in osu! ruleset #28657

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jun 28, 2024

As touched on in #28579. I personally think this makes sense.

Before After
osu! 2024-06-28 at 09 12 50 osu! 2024-06-28 at 09 11 50

@bdach
Copy link
Collaborator

bdach commented Jun 28, 2024

Conceptually seems fine, my only worry would be that this is going to affect existing skins. In worst cases it can make elements go off-screen entirely. Not sure whether that can be avoided in any sane way, though...

@peppy peppy merged commit 56f4f40 into ppy:master Jul 1, 2024
13 of 17 checks passed
@peppy peppy deleted the playfield-skin-components-respect-border branch July 4, 2024 07:43
@april83c
Copy link

my only worry would be that this is going to affect existing skins. In worst cases it can make elements go off-screen entirely.

Can confirm my skin is affected by this (elements off-screen at the bottom):
image

And what it's supposed to look like:
image

I don't like this change because, for my elements to be visible at low circle size (big circles), I have to move my elements really far in, but then on higher circle size (small circles) they feel like they're too close. But also, my skin is really unconventional and the new behavior is probably better for most skins.

It would be nice if both behaviors were available (new one by default but have some way to use the old one), but I have no idea what the UX for that would be (option in skin config/ini? make both available as separate layers? some other way of doing it if anchor point locations get detached from layers?)

Or maybe I should just rethink my skin... it really isn't that big of a deal

(Also another thing to consider: I don't like that updates can break skins; didn't stable have a skin version parameter to keep compatibility with skins made on older versions?)

@peppy
Copy link
Member Author

peppy commented Jul 19, 2024

(Also another thing to consider: I don't like that updates can break skins; didn't stable have a skin version parameter to keep compatibility with skins made on older versions?)

We do our best to avoid this. But sometimes the overhead is not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants