Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for ScreenFooter to house footer content of sheared overlays #28682

Merged
merged 13 commits into from
Jul 10, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jun 30, 2024

In the new song select screen, when opening mod select, ScreenFooter should act as the footer of the overlay, containing buttons like "Deselect All" and side information such as ranking/beatmap attributes display. In order for that to happen, this PR adds an implementation for the ScreenFooter to co-exist with sheared overlays and house its footer content.

Note that no existing overlay in this PR has been updated to display its footer content in ScreenFooter, that's been split off to another PR for review ease.

@bdach
Copy link
Collaborator

bdach commented Jul 9, 2024

Needs merge conflict resolution

@peppy peppy self-requested a review July 10, 2024 04:19
@peppy peppy merged commit 4fe3f39 into ppy:master Jul 10, 2024
11 of 17 checks passed
@frenzibyte frenzibyte deleted the footer-v2-overlay-content branch July 10, 2024 06:08
@frenzibyte frenzibyte self-assigned this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants