-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ManiaModInvert
permanently destroying the beatmap
#28689
Conversation
@smoogipoo please take a look at 005af28. In addition to your changes, I've moved the bindable list portion to |
Any reason for not making it an |
I originally did, but I believe I ran into an issue. Let me check.. |
Reverted the last two commits because they're too ugly to exist, requiring the beatmap class to be reworked in general. |
lgtm. |
Fixes #28687
Steps to reproduce:
Expected: Star rating should be equal to that of NM.
Actual: Star rating differs.
@peppy We may want a hotfix release for this (though I believe it's been broken since the mod's been introduced...).