Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include node samples when changing additions and banks #28711

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 2, 2024

Closes #28603

I'm not necessarily sure the behaviour exercised by the tests here is final, because people are asking for more complicated controls, like being able to hotkey-change samples for individual nodes and stuff, to mirror stable - but I haven't exactly figured out how that could look just yet. This is supposed to be a step in the right direction, rather than a final solution.

@bdach bdach self-assigned this Jul 2, 2024
@peppy peppy self-requested a review July 3, 2024 00:45
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels correct

@peppy peppy merged commit 4ac9d57 into ppy:master Jul 3, 2024
13 of 17 checks passed
@bdach bdach deleted the ternary-state-node-samples branch July 3, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants