Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inheriting addition bank from previous hitobject when using auto bank assignment #28727

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

OliBomby
Copy link
Contributor

@OliBomby OliBomby commented Jul 3, 2024

Placing hit objects with additions would always result in a normal addition bank when using the 'Auto' bank assignment mode. Now it will inherit the addition bank from the previous hit object if it has additions, or inherit from the normal bank if the previous hit object has no additions.

@bdach bdach self-requested a review July 4, 2024 13:05
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 4, 2024
bdach
bdach previously approved these changes Jul 4, 2024
@OliBomby OliBomby dismissed bdach’s stale review July 4, 2024 13:24

The merge-base changed after approval.

@bdach bdach merged commit ab8623e into ppy:master Jul 5, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants