Improve results displays in daily challenge screen #28740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point its primary usage is the daily challenge event feed, but the leaderboard will be using this too shortly. Because the playlists results screen that exists in `master` is hard-coupled to showing the *local user's* best result on a given playlist by way of hard-coupling itself to the relevant API request, allowing show of *arbitrary* score by ID requires a whole bunch of subclassery as things stand. Oh well. Class naming is... best effort, due to the above.
- Actually shows scores rather than playlist aggregates (which are useful... in playlists, where there is more than one item) - Actually allows scores to be shown by clicking on them - Doesn't completely break down visually on smaller window sizes The general appearance is not as polished as the old one in details but I wanted something quick that we can get out by next weekend. Also includes the naive method of refetching scores once a new top 50 score is detected. I can add a stagger if required.
|
@bdach can you check on tests here? i think they need a fix |
|
This is feeling pretty good. One thing I noticed is that clicking a score from the event feed then hitting back will return to the main menu rather than the daily challenge screen. Update: on a second try I couldn't make this happen again... although after viewing results the event feed did empty out which felt a bit weird. |
peppy
reviewed
Jul 9, 2024
peppy
approved these changes
Jul 10, 2024
I can't make this happen either.
Well this is sort of intentional, each event is only supposed to stay on screen for a set amount of time once shown and other screens being pushed don't really affect that in any capacity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is borderline two pulls in one and is a bit chunky as a result but I'm PRing in one go because I'm a bit tired of the ceremony at this point. Will split on request (by commits).
The deets:
Add results screen for displaying arbitrary daily challenge scores
At this point its primary usage is the daily challenge event feed (click the "xxxx points" text to show the score), but the leaderboard will be using this too shortly.
Because the playlists results screen that exists in
masteris hard-coupled to showing the local user's best result on a given playlist by way of hard-coupling itself to the relevant API request, allowing show of arbitrary score by ID requires a whole bunch of subclassery as things stand. Oh well.Class naming is... best effort, due to the above.
Replace old bad daily challenge leaderboard with new implementation
The general appearance is not as polished as the old one in details but I wanted something quick that we can get out by next weekend.
Also includes the naive method of refetching scores once a new top 50 score is detected. I can add a stagger if required.
At this point I'd personally generally say that we can end here for an initial release of this feature by whenever next release happens (tentative date is end of next week?), but am open to feedback if there is opposition.