Apply nullability to MusicController
#28745
Merged
GitHub Actions / Test Results (macOS, SingleThread)
failed
Jul 5, 2024 in 0s
5948 passed, 3 failed and 52 skipped
❌ TestResults-macOS-SingleThread.trx
6003 tests were completed in 1753s with 5948 passed, 3 failed and 52 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Tests.Visual.Online.TestSceneBeatmapListingOverlay | 14✅ | 1❌ | 38s | |
| osu.Game.Tests.Visual.Settings.TestSceneSettingsPanel | 8✅ | 1❌ | 14s | |
| osu.Game.Tests.Visual.SongSelect.TestScenePlaySongSelect | 44✅ | 1❌ | 1⚪ | 18s |
❌ osu.Game.Tests.Visual.Online.TestSceneBeatmapListingOverlay
✅ TestCardSizeSwitching(False)
❌ TestCardSizeSwitching(True)
"all loaded beatmap cards are osu.Game.Beatmaps.Drawables.Cards.BeatmapCardNormal" timed out
✅ TestConstructor
✅ TestCorrectOldContentExpiration
✅ TestDuplicatedBeatmapOnlyShowsOnce
✅ TestExpandedCardContentNotClipped
✅ TestFeaturedArtistFilter
✅ TestHideViaBack
✅ TestHideViaBackWithScrolledSearch
✅ TestHideViaBackWithSearch
✅ TestNoBeatmapsPlaceholder
✅ TestUserWithoutSupporterUsesSupporterOnlyFiltersWithoutResults
✅ TestUserWithoutSupporterUsesSupporterOnlyFiltersWithResults
✅ TestUserWithSupporterUsesSupporterOnlyFiltersWithoutResults
✅ TestUserWithSupporterUsesSupporterOnlyFiltersWithResults
❌ osu.Game.Tests.Visual.Settings.TestSceneSettingsPanel
✅ TestBasic
✅ TestConstructor
❌ TestFilterAfterLoad
"wait for items to load" timed out
✅ TestFiltering(False)
✅ TestFiltering(True)
✅ TestSearchTextBoxSelectedOnShow
✅ TestTextboxFocusAfterNestedPanelBackButton
✅ TestTextboxFocusAfterNestedPanelEscape
✅ ToggleVisibility
❌ osu.Game.Tests.Visual.SongSelect.TestScenePlaySongSelect
✅ TestAudioRemainsCorrectOnRulesetChange(False)
✅ TestAudioRemainsCorrectOnRulesetChange(True)
✅ TestAudioResuming
✅ TestAutoplayShortcut
✅ TestAutoplayShortcutKeepsAutoplayIfSelectedAlready
✅ TestAutoplayShortcutReturnsInitialModsOnExit
✅ TestBeatmapOptionsDisabled
✅ TestCarouselSelectionUpdatesOnResume
✅ TestChangeBeatmapAfterEnter
✅ TestChangeBeatmapBeforeEnter
✅ TestChangeBeatmapViaMouseAfterEnter
✅ TestChangeBeatmapViaMouseBeforeEnter
✅ TestChangeBeatmapWhilePresentingScore
✅ TestChangeRulesetWhilePresentingScore
✅ TestChangingRulesetOnMultiRulesetBeatmap
✅ TestConstructor
✅ TestCutInFilterTextBox
✅ TestDeleteHotkey
✅ TestDifficultyIconSelecting
✅ TestDifficultyIconSelectingForDifferentRuleset
✅ TestDummy
✅ TestExternalBeatmapChangeWhileFiltered(False)
✅ TestExternalBeatmapChangeWhileFiltered(True)
✅ TestExternalBeatmapChangeWhileFilteredThenRefilter
✅ TestFilterableModChange
✅ TestFilterOnResumeAfterChange
✅ TestGroupedDifficultyIconSelecting
✅ TestHideSetSelectsCorrectBeatmap
✅ TestImportUnderCurrentRuleset
✅ TestImportUnderDifferentRuleset
✅ TestModOverlayToggling
✅ TestModsRetainedBetweenSongSelect
✅ TestNoFilterOnSimpleResume
✅ TestNonFilterableModChange
✅ TestPlaceholderBeatmapPresence
✅ TestPlaceholderConvertSetting
✅ TestPlaceholderStarDifficulty
✅ TestPresentNewBeatmapNewRuleset
✅ TestPresentNewRulesetNewBeatmap
✅ TestSearchTextWithRulesetCriteria
⚪ TestSelectionRetainedOnBeatmapUpdate
✅ TestSingleFilterOnEnter
✅ TestSorting
✅ TestSpeedChange
✅ TestStartAfterUnMatchingFilterDoesNotStart
❌ TestTextBoxBeatmapDifficultyCount
"wait for present" timed out
Annotations
Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs
github-actions / Test Results (macOS, SingleThread)
osu.Game.Tests.Visual.Online.TestSceneBeatmapListingOverlay ► TestCardSizeSwitching(True)
Failed test found in:
TestResults-macOS-SingleThread.trx
Error:
"all loaded beatmap cards are osu.Game.Beatmaps.Drawables.Cards.BeatmapCardNormal" timed out
Raw output
"all loaded beatmap cards are osu.Game.Beatmaps.Drawables.Cards.BeatmapCardNormal" timed out
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs
github-actions / Test Results (macOS, SingleThread)
osu.Game.Tests.Visual.Settings.TestSceneSettingsPanel ► TestFilterAfterLoad
Failed test found in:
TestResults-macOS-SingleThread.trx
Error:
"wait for items to load" timed out
Raw output
"wait for items to load" timed out
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs
github-actions / Test Results (macOS, SingleThread)
osu.Game.Tests.Visual.SongSelect.TestScenePlaySongSelect ► TestTextBoxBeatmapDifficultyCount
Failed test found in:
TestResults-macOS-SingleThread.trx
Error:
"wait for present" timed out
Raw output
"wait for present" timed out
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Loading