Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor playback control not removing correct adjustment #28770

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix editor playback control not removing correct adjustment #28770

merged 2 commits into from
Jul 8, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 8, 2024

great job past me 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤬🤬🤬

bdach added 2 commits July 8, 2024 13:21
@bdach
Add failing test case
6433f29
@bdach
Fix editor playback control not removing correct adjustment
0fe2c45 
Closes ppy#28768.

great job past me 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦
@bdach bdach added area:editor audio next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Jul 8, 2024
@smoogipoo smoogipoo enabled auto-merge July 8, 2024 11:43
@smoogipoo smoogipoo merged commit 5cae005 into ppy:master Jul 8, 2024
9 of 11 checks passed
@bdach bdach deleted the really-now branch July 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:editor audio next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playback speed did not recover when exit editor
2 participants
@bdach @smoogipoo