Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign editor timelines to address most frequent user complaints #28788

Merged
merged 15 commits into from
Jul 12, 2024
Merged

Redesign editor timelines to address most frequent user complaints #28788

merged 15 commits into from
Jul 12, 2024

Commits on Jul 9, 2024

  1. Ensure timeline ticks aren't hidden by other pieces 

    Addresses ppy#28667.
    @bdach
    bdach committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    50818da View commit details
    Browse the repository at this point in the history

  2. Slim down bottom timeline 

    This removes the BPM display, which is commonly cited to have
no functional purpose by users, and reduces the height of the bottom bar
in exchange for more space for the playfield.
    @bdach
    bdach committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    29b8948 View commit details
    Browse the repository at this point in the history

  3. Redesign bottom timeline pieces to match stable better

    @bdach
    bdach committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5d5dd0d View commit details
    Browse the repository at this point in the history

  4. Remove unused using

    @bdach
    bdach committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ca4c0aa View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'master' into timeline-redesign

    @peppy
    peppy committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    95464eb View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add back BPM and adjust sizing of bottom bar a bit more

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fb4f620 View commit details
    Browse the repository at this point in the history

  2. Change red shade for timing control points

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e6b7d25 View commit details
    Browse the repository at this point in the history

  3. Adjust various visuals of summary timeline in a hope for user acceptance 

    .. with a somewhat appealing design.
    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    685b19a View commit details
    Browse the repository at this point in the history

  4. Adjust timeline ticks to add a bit more body back

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9a7a0cd View commit details
    Browse the repository at this point in the history

  5. Add slight offset for timeline BPM display to avoid overlaps

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2ad2ae0 View commit details
    Browse the repository at this point in the history

  6. Adjust breaks in timeline to be centered with waveform / hitobjects

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f65ab67 View commit details
    Browse the repository at this point in the history

  7. Adjust timeline centre marker visuals and bring in front of ticks

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ca2fc72 View commit details
    Browse the repository at this point in the history

  8. Fix test regression

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    43addc8 View commit details
    Browse the repository at this point in the history

  9. Add a bit more padding between node overlays and hitobjects in timeline

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d2cb07b View commit details
    Browse the repository at this point in the history

  10. Reduce opacity of centre marker slightly

    @peppy
    peppy committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4be5d05 View commit details
    Browse the repository at this point in the history