Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of automatic break regeneration #28801

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Improve performance of automatic break regeneration #28801

merged 2 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. Do not regenerate breaks unless meaningful change to object start/end… 

    … times is detected

Tangentially found when profiling ppy#28792.

For reproduction, import https://osu.ppy.sh/beatmapsets/972#osu/9007,
move any object on the playfield, and observe a half-second freeze
when ending the drag.
    @bdach
    bdach committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    343090e View commit details
    Browse the repository at this point in the history

  2. Pool summary timeline break visualisations to reduce allocations

    @bdach
    bdach committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b881c25 View commit details
    Browse the repository at this point in the history