Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup screen controls that do nothing useful #28806

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 10, 2024

Before I go with a hammer to redesign these, I want to remove stuff that does nothing first.

Hard-breaks API to allow rulesets to specify an enumerable of custom sections rather than two specific weird ones. Can probably try to make it less hard-breaking if deemed required, but I don't really see the point (custom ruleset editors are 100% not usable right now anyways)

For specific rulesets:

  • osu!:
    • Stack leniency slider merged into difficulty section.
  • osu!taiko:
    • Approach rate and circle size sliders removed.
    • Colours section removed.
  • osu!catch:
    • No functional changes.
  • osu!mania:
    • Special style toggle merged into difficulty section.
    • Colours section removed.

Code duplication incurred here is intentional. Review comments suggesting creation of eldritch abstract entities will be unilaterally ignored.

Before I go with a hammer to redesign these, I want to remove stuff that
does nothing first.

Hard-breaks API to allow rulesets to specify an enumerable of custom
sections rather than two specific weird ones.

For specific rulesets:

- osu!:
  - Stack leniency slider merged into difficulty section.
- osu!taiko:
  - Approach rate and circle size sliders removed.
  - Colours section removed.
- osu!catch:
  - No functional changes.
- osu!mania:
  - Special style toggle merged into difficulty section.
  - Colours section removed.
@peppy peppy self-requested a review July 10, 2024 13:46
@peppy peppy merged commit b0e2462 into ppy:master Jul 10, 2024
8 of 11 checks passed
@bdach bdach deleted the remove-irrelevant-stuff-from-setup branch July 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants