Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BackgroundDataStoreProcessor test failure #28884

Merged
merged 4 commits into from
Jul 17, 2024

Fix rank upgrade path upgrading scores that failed background reproce…

7ba1f14
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix BackgroundDataStoreProcessor test failure #28884

Fix rank upgrade path upgrading scores that failed background reproce…
7ba1f14
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Jul 16, 2024 in 1s

5984 passed, 2 failed and 52 skipped

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

6038 tests were completed in 3464s with 5984 passed, 2 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneArgonHealthDisplay 5✅ 1❌ 13s
osu.Game.Tests.Visual.Navigation.TestSceneBeatmapEditorNavigation 13✅ 1❌ 45s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneArgonHealthDisplay

✅ TestConstructor
✅ TestHealthDisplayIncrementing
✅ TestLateMissAfterConsequentMisses
✅ TestMissAlmostExactlyAfterLastMissAnimation
❌ TestMissThenHitAtSameUpdateFrame
	"wait for health" timed out
✅ TestSimulateDrain

❌ osu.Game.Tests.Visual.Navigation.TestSceneBeatmapEditorNavigation

✅ TestAttemptGlobalMusicOperationFromEditor
❌ TestCancelNavigationToEditor
	"Wait for menu" timed out
✅ TestChangeMetadataExitWhileTextboxFocusedPromptsSave
✅ TestConstructor
✅ TestCreateNewDifficultyOnNonExistentBeatmap
✅ TestEditorGameplayTestAlwaysUsesOriginalRuleset
✅ TestExitEditorWithoutSelection
✅ TestExitEditorWithSelection
✅ TestExternalEditingNoChange
✅ TestExternalEditingWithChange
✅ TestLastTimestampRememberedOnExit
✅ TestSaveThenDeleteActuallyDeletesAtSongSelect
✅ TestSelectionRetainedOnExit(Difficulty)
✅ TestSelectionRetainedOnExit(Title)

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneArgonHealthDisplay ► TestMissThenHitAtSameUpdateFrame

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "wait for health" timed out
Raw output
"wait for health" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Tests.Visual.Navigation.TestSceneBeatmapEditorNavigation ► TestCancelNavigationToEditor

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "Wait for menu" timed out
Raw output
"Wait for menu" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)