-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more test failures #28900
Fix more test failures #28900
Commits on Jul 18, 2024
-
Fix TestTouchScreenDetectionAtSongSelect test failure
https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295 In this case, the settings overlay is taking a very long time to load (on a background thread), and pops in when it finishes loading because it's been requested to open. The opens the settings overlay, closes it (by pressing escape, this does not actually close it because it's not loaded yet), and then enters song select by pressing 'P' 3 times. The settings overlay finishes loading at just the right opportune moment to eat one of the 'P' key presses.
Configuration menu - View commit details
-
Copy full SHA for 1906c2f - Browse repository at this point
Copy the full SHA 1906c2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bb680a - Browse repository at this point
Copy the full SHA 7bb680aView commit details -
Fix TestAllSamplesStopDuringSeek test failure
https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263 This is a bit of a workaround, likely timing related. I don't foresee an until step in this case to cause false-passes.
Configuration menu - View commit details
-
Copy full SHA for f3cd3d7 - Browse repository at this point
Copy the full SHA f3cd3d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a81d8 - Browse repository at this point
Copy the full SHA 33a81d8View commit details -
Fix TestPostAsOwner test failure
https://github.com/smoogipoo/osu/actions/runs/9990112749/job/27610257309 Comments are loaded asynchronously, both from the initial request and the following message-post request. By sheer timing luck, these could be out of order and the assertion on the posted message could fail.
Configuration menu - View commit details
-
Copy full SHA for 3f4e56b - Browse repository at this point
Copy the full SHA 3f4e56bView commit details
Commits on Jul 19, 2024
-
Fix TestCancelNavigationToEditor test failure
https://github.com/ppy/osu/actions/runs/10002179087/job/27648253709 The editor could be pushed before the exit actually occurs.
Configuration menu - View commit details
-
Copy full SHA for d7ae950 - Browse repository at this point
Copy the full SHA d7ae950View commit details -
Attempt to fix TestSelectableMouseHandling test failure
https://github.com/ppy/osu/pull/28900/checks?check_run_id=27652166871 This is an attempt. Going frame-by-frame I noticed that there's one frame in which the text is loaded but the FillFlowContainer/GridContainer haven't properly validated so the text is not positioned correctly (it's overflowing the panel to the left). If the cursor is moved at this exact time, then it may not be properly positioned for the following assertion, even though it is _somewhere_ on the panel. If the above is the case, then this is a known o!f issue, but not a simple one to solve. I haven't reproed this locally.
Configuration menu - View commit details
-
Copy full SHA for 7a4758d - Browse repository at this point
Copy the full SHA 7a4758dView commit details -
Add beatmap name to log string
Makes it easy to compare this line versus the one in OsuGame.PresentBeatmap(). At the moment it's just GUID which is... not useful!
Configuration menu - View commit details
-
Copy full SHA for 5af39aa - Browse repository at this point
Copy the full SHA 5af39aaView commit details