Fix held gameplay keys stuck after pausing and resuming #28954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn event does not cause a gameplay press
If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.
frenzibyte
added
area:gameplay
type:input
next release
peppy
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PassThroughInputManagerin input queue even while parent input is disabled osu-framework#6340As mentioned at the bottom of ppy/osu-framework#6340, this PR schedules the resume operation to next frame when clicking on the osu! click-to-resume cursor.
This PR also makes the pause overlay not block key input from passing down to the ruleset input manager, so that any key that is held before pause will be seen by the input manager, making its release counterpart also seen.
There are a list of test cases attached in this PR that ensures input handling w.r.t. pause is done correctly.