Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect pre-empt time when auto-generating breaks #29021

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 23, 2024

Closes #28703.

Before:

2024-07-23.13-44-28.mp4

After:

2024-07-23.13-45-35.mp4

Map / timestamp used for video: https://osu.ppy.sh/beatmapsets/2113786#osu/4566218, 01:08:715 (11,12,13,14,15)

@peppy peppy merged commit aded31b into ppy:master Jul 24, 2024
13 of 17 checks passed
@bdach bdach deleted the editor-breaks-respect-time-preempt branch July 24, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Editor timeline break period ignores the Approach circle timing
2 participants