Exit daily challenge screen when going offline #29037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...
bdach
commented
Jul 24, 2024
| @@ -99,6 +99,7 @@ private void forcefullyExit() | |||
| Logger.Log($"{this} forcefully exiting due to loss of API connection"); | |||
|
|
|||
| // This is temporary since we don't currently have a way to force screens to be exited | |||
| // See also: `DailyChallenge.forcefullyExit()` | |||
There was a problem hiding this comment.
Readers will note that this copy of this logic contains an else branch that claims that it is "[handling] the case where a child screen is current (ie. gameplay)."
Dear reader, it does not, because the invocation of this method is copiously scheduled:
osu/osu.Game/Screens/OnlinePlay/OnlinePlayScreen.cs
Lines 78 to 82 in aded31b
which means it will not get called if the screen is not current. So this just doesn't work. This particular oopsie blames back to 5b405ab which means I am not touching it with a ten foot pole here. (Unless you'd like me to remove it?)
peppy
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...