Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit daily challenge screen when going offline #29037

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 24, 2024

This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...

This sort of thing is bound to happen when rewriting screens from
scratch without invoking abstract eldritch entities sometimes. Damned if
you do, damned if you don't...
@@ -99,6 +99,7 @@ private void forcefullyExit()
Logger.Log($"{this} forcefully exiting due to loss of API connection");

// This is temporary since we don't currently have a way to force screens to be exited
// See also: `DailyChallenge.forcefullyExit()`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readers will note that this copy of this logic contains an else branch that claims that it is "[handling] the case where a child screen is current (ie. gameplay)."

Dear reader, it does not, because the invocation of this method is copiously scheduled:

private void onlineStateChanged(ValueChangedEvent<APIState> state) => Schedule(() =>
{
if (state.NewValue != APIState.Online)
Schedule(forcefullyExit);
});

which means it will not get called if the screen is not current. So this just doesn't work. This particular oopsie blames back to 5b405ab which means I am not touching it with a ten foot pole here. (Unless you'd like me to remove it?)

@peppy peppy merged commit 65fcef1 into ppy:master Jul 24, 2024
15 of 17 checks passed
@bdach bdach deleted the daily-challenge-exit-when-offline branch July 24, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants