Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when toggling extended statistics visibility during results load #29068

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 25, 2024

Closes #29066.

Initially I fixed this at where the assert is right now:

Debug.Assert(SelectedScore.Value != null);

but because of the weird way that visible state management is done in this screen that made it possible for the extended statistics to be visible behind the score panels, without the score panels making way for it. So this is in a way safer, because it prevents the visibility state of the extended statistics from changing in the first place if there is no score selected (yet).

This can be also seen in playlists, at least.

… load

Closes ppy#29066.

Initially I fixed this at where the assert is right now:

	https://github.com/ppy/osu/blob/9790c5a574b782c41c8c6da99ad8c42dfadc9de8/osu.Game/Screens/Ranking/ResultsScreen.cs#L333

but because of the weird way that visible state management is done in
this screen that made it possible for the extended statistics to be
visible *behind* the score panels, without the score panels making way
for it. So this is in a way safer, because it prevents the visibility
state of the extended statistics from changing in the first place if
there is no score selected (yet).

This can be also seen in playlists, at least.
@bdach bdach self-assigned this Jul 25, 2024
@bdach bdach added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Jul 25, 2024
@peppy peppy merged commit c90e040 into ppy:master Jul 25, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:results next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/XS type:reliability
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Press space when result panel loading will cause error
2 participants