Change default control point sample bank to use custom hitsounds #29084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am 99.9999% certain this is wrong, and tests will show as much. The reason is because this affects the decode process as well, but the change should instead be contained to the editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #29028
Description
Currently, control points created in Lazer are created via
LegacyHitSampleInfowith customSampleBank 0, which is the equivalent of Sampleset Default in Stable. This causes custom hitsounds added with "Edit externally" to not persist properly (see #29028)This PR changes the default customSampleBank to 1, which is the equivalent of Sampleset Custom 1 in Stable.
Potential issues
SamplePointPiece, similar to Addition Bank?PR-CustomSampleBank.webm