Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statistics wedge not showing correct values in daily challenge #29100

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

cbrwn
Copy link
Contributor

@cbrwn cbrwn commented Jul 26, 2024

Hey friends! Thought this was a decent issue to look at as my first contribution 😃

Fixes #29094

I did wonder if this should be done in a value changed binding on OsuScreen.Beatmap, but this seems simple & clear enough that this should happen when we do other beatmap setting stuff

@bdach bdach self-requested a review July 26, 2024 08:20
@bdach bdach changed the title Update the beatmap of Daily Challenge's mods overlay when beatmap is set - #29094 Fix statistics wedge not showing correct values in daily challenge Jul 26, 2024
@bdach bdach added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Jul 26, 2024
@cbrwn
Copy link
Contributor Author

cbrwn commented Jul 26, 2024

Turns out I'm a noob at GitHub's pull request flow - I think I totally could've taken your change directly from that suggestion @bdach 😅

@bdach
Copy link
Collaborator

bdach commented Jul 26, 2024

I think I totally could've taken your change directly from that suggestion

Nah that was not a github suggestion, that was a git patch. If you could commit directly via github there'd be a button (but there's none).

@cbrwn
Copy link
Contributor Author

cbrwn commented Jul 26, 2024

Nah that was not a github suggestion, that was a git patch. If you could commit directly via github there'd be a button (but there's none).

Ah gotcha! Is there anything else I needa do for this?

@bdach
Copy link
Collaborator

bdach commented Jul 26, 2024

Ah gotcha! Is there anything else I needa do for this?

Nope

@bdach bdach merged commit 2b083bf into ppy:master Jul 26, 2024
13 checks passed
@cbrwn cbrwn deleted the daily-mods-stats branch July 26, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:daily-challenge next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/XS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Statistics wedge shows values of 0 in daily challenge
2 participants