Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Beatmap not downloaded" tooltip hint not showing in online play #29115

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 26, 2024

There are two Enableds. The base one includes download state so it should be the one checked for early return.

Kinda bad implementation but let's just make it work for now.

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@bdach bdach changed the title Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge Fix "Beatmap not downloaded" tooltip hint not showing in online play Jul 26, 2024
@peppy peppy merged commit f2a3805 into ppy:master Jul 26, 2024
8 of 9 checks passed
@peppy peppy deleted the fix-download-tooltip-text branch July 29, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants