Force exit to main menu when presenting scores from within playlists / multiplayer #29182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing I failed to predict that in multiplayer there can be a different beatmap in the playlist queue. If this is the case,
PresentScore()
will exit out toMultiplayer
, whoseRoomSubScreen
will update the selected item - and thus, the global beatmap - to the next item in queue, at which point trying to play games with "not touching the global beatmap bindable if we don't need to" fail to work, because the bindable must be touched for correct operation, yet it cannot (becauseOnlinePlayScreen
s disable it).I'm not sure what the fix is here:
so I'm just reverting the broken part. The daily challenge part is left in because as is it should not cause issues.