Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix online status not persisting correctly #29186

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 29, 2024

Regressed at some point. Can't find why but oh well.

I don't see much reason not to link the bindable directly with config. It seems to work as you'd expect. Tested with logout (resets to "Online") and connection failure (persists). Not going to overthink this until we have full support for it.

Closes #29173.

Regressed at some point.

I don't see much reason not to link the bindable directly with config.
It seems to work as you'd expect. Tested with logout (resets to
"Online") and connection failure (persists).

Closes ppy#29173.
@bdach bdach self-requested a review July 29, 2024 13:56
@bdach
Copy link
Collaborator

bdach commented Jul 29, 2024

fef8afb833b7ddfd42b97260faff7593da514868 is the first bad commit
commit fef8afb833b7ddfd42b97260faff7593da514868
Author: Dean Herbert <pe@ppy.sh>
Date:   Fri Mar 29 12:03:05 2024 +0800

    Fix double binding causing game crash after API enters failing state
    
    See https://sentry.ppy.sh/organizations/ppy/issues/33406/?alert_rule_id=4&alert_timestamp=1711655107332&alert_type=email&environment=production&project=2&referrer=alert_email

 osu.Game/Overlays/Login/LoginPanel.cs | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this doesn't seem broken

@bdach bdach merged commit 48e38bd into ppy:master Jul 29, 2024
13 checks passed
@peppy peppy deleted the fix-status-config branch July 30, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online status gets reset the next time you open the game
2 participants