Limit maximum tooltip width to prevent overflow

[normalid-awa]

Replace the default IHasTooltip with IHasCustomTooltip<LocalisableString> and use the new custom tooltip CommentTooltip with TextFlowContainer to limit the width of the tooltip.

Master
PR

[bdach]

I dunno. This is not worth a custom tooltip to me

If we're going to be chasing these instance by instance then I'd rather just honestly see OsuTooltip have a fixed max width and use a TextFlowContainer everywhere to avoid this. Or Truncate set, either or.

Curious of @ppy/team-client opinion.

[smoogipoo]

Agree with the above, should be fairly easy to make it use TFC.

[normalid-awa]

I've changed the OsuTooltip text to TFC and limited the width, so it should be fixing all potential visual bugs (tooltip overflow).

[smoogipoo]

Requesting one more review to confirm I haven't gone off the rails with my suggestions (especially maximum size of 500).

[peppy]

@smoogipoo how are you testing this? is there a test scene i'm missing?

[normalid-awa]

@smoogipoo how are you testing this? is there a test scene i'm missing?

I think there's no test scene to test the tooltips, I think I could probably open a pr to implement that.

[normalid-awa]

@smoogipoo how are you testing this? is there a test scene i'm missing?

I've written the unit test now, not sure if I have to open a new pr or just push to this branch

[peppy]

@normalid-awa you can commit here

[normalid-awa]

@normalid-awa you can commit here

Unit test was pushed, One of the test was temporarily disabled due to the o!f issue. ref discussion

[peppy]

@normalid-awa please check the changes i made to your tests to improve things slightly. otherwise looks fine!

[normalid-awa]

@normalid-awa please check the changes i made to your tests to improve things slightly. otherwise looks fine!

Oh...., I was a bit confused at that point, the test should be enable but only disabled the problem case. The changes looks good to me!