Close context menus when deselecting items in editor

[normalid-awa]

Closed #29132

Implementation:

• Expose CloseMenu method in OsuContextMenuContainer
• Cache OsuContextMenuContainer At the SkinEditor and Editor
• Resolve OsuContextMenuContainer in SelectionHandler
• Call OsuContextMenuContainer.CloseMenu method when SelectionHandler.DeselectAll was called

Video

Beatmap editor:

2024-08-04.20-00-52.mp4

Skin editor:

2024-08-04.20-01-40.mp4

[smoogipoo]

One situation I'm not sure about is that pasting doesn't close the menu even though it selects the newly-pasted hitobjects.

[normalid-awa]

One situation I'm not sure about is that pasting doesn't close the menu even though it selects the newly-pasted hitobjects.

close the menu whatever the selected object changed

        internal virtual void HandleSelected(SelectionBlueprint<T> blueprint)
        {
            // there are potentially multiple SelectionHandlers active, but we only want to add items to the selected list once.
            if (!SelectedItems.Contains(blueprint.Item))
                SelectedItems.Add(blueprint.Item);

            selectedBlueprints.Add(blueprint);

+            ContextMenuContainer?.CloseMenu();
        }

[smoogipoo]

Just cleaned things up a bit for review. Lgtm. Requesting another reviewer.

I noticed one problem with context menus in general - if a mouse down is handled inside them then the menu isn't closed. It's an issue here because BlueprintContainer handles it, but it can't be fixed in this PR (and is likely an o!f issue):

osu/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs

Lines 114 to 131 in d637bbf

	protected override bool OnMouseDown(MouseDownEvent e)
	{
	bool selectionPerformed = performMouseDownActions(e);
	bool movementPossible = prepareSelectionMovement(e);
	// check if selection has occurred
	if (selectionPerformed)
	{
	// only unmodified right click should show context menu
	bool shouldShowContextMenu = e.Button == MouseButton.Right && !e.ShiftPressed && !e.AltPressed && !e.SuperPressed;
	// stop propagation if not showing context menu
	return !shouldShowContextMenu;
	}
	// even if a selection didn't occur, a drag event may still move the selection.
	return e.Button == MouseButton.Left && movementPossible;
	}

[bdach]

What's this change doing? @smoogipoo looks like one of yours?

I'm not sure it's a big deal but I'm weirded out by it.

[smoogipoo]

Previously, the context menu container was stored as a local and cached in this class. Now, the context menu container caches itself via [Cached] on the type itself.

But this moves the dependencies one level lower from Editor itself, and previously this line would load the screen with the dependencies of the Editor rather than the expected lower level.