Add "enter" hint to in-gameplay chatbox placeholder text

[kstefanowicz]

• Closes Add hint to press enter key for focusing in-gameplay chat #29264

I don't know how to get to a multiplayer game in a debug build, so I was not able to confirm if this works.

[smoogipoo]

I'm not sure about:

1. The length of the placeholder in general. It feels too verbose but I'm not sure how to improve it.
2. The placeholder still saying "press enter [...]" while it already has focus.

Regarding the second from the above, I experimented with something like this:

diff --git a/osu.Game/Online/Chat/StandAloneChatDisplay.cs b/osu.Game/Online/Chat/StandAloneChatDisplay.cs
index 3a094cc074..e100b5fe5b 100644
--- a/osu.Game/Online/Chat/StandAloneChatDisplay.cs
+++ b/osu.Game/Online/Chat/StandAloneChatDisplay.cs
@@ -128,6 +128,9 @@ private void channelChanged(ValueChangedEvent<Channel> e)
 
         public partial class ChatTextBox : HistoryTextBox
         {
+            public Action Focus;
+            public Action FocusLost;
+
             protected override bool OnKeyDown(KeyDownEvent e)
             {
                 // Chat text boxes are generally used in places where they retain focus, but shouldn't block interaction with other
@@ -153,13 +156,17 @@ protected override void LoadComplete()
                 BackgroundFocused = new Color4(10, 10, 10, 255);
             }
 
+            protected override void OnFocus(FocusEvent e)
+            {
+                base.OnFocus(e);
+                Focus?.Invoke();
+            }
+
             protected override void OnFocusLost(FocusLostEvent e)
             {
                 base.OnFocusLost(e);
                 FocusLost?.Invoke();
             }
-
-            public Action FocusLost;
         }
 
         public partial class StandAloneDrawableChannel : DrawableChannel
diff --git a/osu.Game/Screens/OnlinePlay/Multiplayer/GameplayChatDisplay.cs b/osu.Game/Screens/OnlinePlay/Multiplayer/GameplayChatDisplay.cs
index 656071ad43..d1a73457e3 100644
--- a/osu.Game/Screens/OnlinePlay/Multiplayer/GameplayChatDisplay.cs
+++ b/osu.Game/Screens/OnlinePlay/Multiplayer/GameplayChatDisplay.cs
@@ -42,8 +42,13 @@ public GameplayChatDisplay(Room room)
 
             Background.Alpha = 0.2f;
 
-            TextBox.FocusLost = () => expandedFromTextBoxFocus.Value = false;
             TextBox.PlaceholderText = ChatStrings.InGameInputPlaceholder;
+            TextBox.Focus = () => TextBox.PlaceholderText = Resources.Localisation.Web.ChatStrings.InputPlaceholder;
+            TextBox.FocusLost = () =>
+            {
+                TextBox.PlaceholderText = ChatStrings.InGameInputPlaceholder;
+                expandedFromTextBoxFocus.Value = false;
+            };
         }
 
         protected override bool OnHover(HoverEvent e) => true; // use UI mouse cursor.

Screen.Recording.2024-08-05.at.12.37.08.mov

But I'm still not too sure about it. Need a secondary opinion.

[frenzibyte]

"press enter to chat..." could work better as a shorter placeholder.

[kstefanowicz]

1. The length of the placeholder in general. It feels too verbose but I'm not sure how to improve it.

"press enter to chat..." is definitely better, I will change that now

2. The placeholder still saying "press enter [...]" while it already has focus.

That implementation makes sense, agreed. I believe that multiplayer in-game is the only place where the chatbox isn't in focus at all times, so the Focus events may be able to be applied to just GameplayChatDisplay and not the parent StandAloneChatDisplay edit - I'm bad at reading code, thank you for your patience

[peppy]

@kstefanowicz are you going to apply the proposed change to the placeholder text when focused?

[kstefanowicz]

Placeholder text hover change has been applied. Thank you for your patience.