Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow object deletion with middle mouse #29286

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Allow object deletion with middle mouse #29286

merged 3 commits into from
Aug 6, 2024

Commits on Aug 5, 2024

  1. Allow placement deletion with middle mouse 

    This is in addition to Shift + Right-click.

I thik middle mouse feels more natural and is a good permanent solution
to this issue.

Note that this also *allows triggering the context menu from placement
mode*. Until now it's done nothing. This may be annoying to users with
muscle memory but I want to make the change and harvest feedback. I
think showing the context menu is more correct behaviour (although
arguably it should return to placement mode on dismiss?).
    @peppy
    peppy committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    0557b9a View commit details
    Browse the repository at this point in the history

  2. Add test coverage of right/middle click behaviours with placement blu… 

    …eprints
    @peppy
    peppy committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9673985 View commit details
    Browse the repository at this point in the history

  3. Add test of existing slider placement behaviour for safety

    @peppy
    peppy committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c0814c2 View commit details
    Browse the repository at this point in the history