Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change non-legacy control points to have CustomSampleBank 1 #29311

Closed
wants to merge 6 commits into from
Closed

Change non-legacy control points to have CustomSampleBank 1 #29311

wants to merge 6 commits into from

Commits on Aug 6, 2024

  1. Change toLegacyCustomSampleBank fallback from 0 to 1

    @kstefanowicz
    kstefanowicz committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5b52fc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Change logic to create non-legacy sample points with customSampleBank 1

    @kstefanowicz
    kstefanowicz committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    35e8f5e View commit details
    Browse the repository at this point in the history

  2. Adjust formatting

    @kstefanowicz
    kstefanowicz committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    81f00a3 View commit details
    Browse the repository at this point in the history

  3. Address dereference warning

    @kstefanowicz
    kstefanowicz committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    8299a0b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Change createSampleC ontrolPointFor fallback from -1 to 1

    @kstefanowicz
    kstefanowicz committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    730f198 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Refactor if/else as ternary conditional

    @kstefanowicz
    kstefanowicz committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    18dc375 View commit details
    Browse the repository at this point in the history