Start playing the daily challenge track during the intro (and automatically download) #29347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sponsor
Member
peppy
commented
Aug 8, 2024
•
peppy
commented
- Depends on Add intro screen for daily challenge #29323 for ease of review
2 tasks
bdach
approved these changes
Aug 12, 2024
| @@ -503,17 +494,30 @@ public override bool OnExiting(ScreenExitEvent e) | |||
| return base.OnExiting(e); | |||
| } | |||
|
|
|||
| private void applyLoopingToTrack() | |||
| public static void TrySetDailyChallengeBeatmap(OsuScreen screen, BeatmapManager beatmaps, RulesetStore rulesets, MusicController music, PlaylistItem item) | |||
There was a problem hiding this comment.
Slight teeth pain at this method's public-static-dependency-accepting shape but I guess it's localised so probably fine. Likely better than weird inheritance anyhow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.