Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement song select v2 difficulty name content component #29415

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Implement song select v2 difficulty name content component #29415

merged 10 commits into from
Aug 15, 2024

Commits on Aug 14, 2024

  1. Add base song select components test scene

    @Joehuu
    Joehuu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    46d41cb View commit details
    Browse the repository at this point in the history

  2. Implement song select v2 difficulty name content component

    @Joehuu
    Joehuu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    625c6fc View commit details
    Browse the repository at this point in the history

  3. Workaround single-frame layout issues with `{Link|Text|Fill}FlowConta… 

    …iner`s
    @Joehuu
    Joehuu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2b41f71 View commit details
    Browse the repository at this point in the history

  4. Move resizing width and background logic to `SongSelectComponentsTest… 

    …Scene`
    @Joehuu
    Joehuu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f8796e3 View commit details
    Browse the repository at this point in the history

  5. Directly resolve IBindable<WorkingBeatmap> by making a local varian… 

    …t of `DifficultyNameContent`
    @Joehuu
    Joehuu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c24f144 View commit details
    Browse the repository at this point in the history

  6. Move other V2 tests to new test namespace

    @peppy
    peppy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2174510 View commit details
    Browse the repository at this point in the history

  7. Inline single-frame layout issue comment instead

    @Joehuu
    Joehuu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    11bd0c9 View commit details
    Browse the repository at this point in the history

  8. Use Content override instead

    @Joehuu
    Joehuu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6f2bc7e View commit details
    Browse the repository at this point in the history

  9. Fix failing test setup

    @peppy
    peppy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1665d9a View commit details
    Browse the repository at this point in the history

  10. Update remaining tests to use new base class (and tidy up V2 suffixes)

    @peppy
    peppy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e603888 View commit details
    Browse the repository at this point in the history