Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "hold for menu" button to only show for touch by default #29508

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Aug 19, 2024

Addresses #28049.

This also increases the visibility on touch platforms (it used to be positional based, which doesn't make much sense).

smoogipoo
smoogipoo previously approved these changes Aug 19, 2024
@bdach
Copy link
Collaborator

bdach commented Aug 19, 2024

Tests red here.

@smoogipoo smoogipoo merged commit 44213a3 into ppy:master Aug 20, 2024
13 checks passed
@peppy peppy deleted the hold-for-menu-sometimes branch August 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants